Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 17, 2025

Description

Follow up of #383
Reported in Slack: https://stackable-workspace.slack.com/archives/C053Z21C9QW/p1760446364220949

Currently we don't run on Ubuntu 22.02 or Debian bookworm. This PR fixes that.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Oct 17, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 17, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but I wouldn't declare this a fix. This should instead be ci.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 17, 2025
@sbernauer
Copy link
Member Author

At first glance "build" or "chore" sounds more correct according to https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type.
Because we not only change the CI, but the actual binary that is build and ship.
But I let you make the final call

@Techassi
Copy link
Member

Yes, build also works.

@sbernauer sbernauer changed the title fix(stackablectl): Make binary more portable by downgrading glibc version build(stackablectl): Make binary more portable by downgrading glibc version Oct 17, 2025
@sbernauer sbernauer requested a review from Techassi October 17, 2025 13:22
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 20, 2025
@sbernauer sbernauer added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit a31686d Oct 20, 2025
22 checks passed
@sbernauer sbernauer deleted the chore/binary-glibc-version branch October 20, 2025 09:30
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants