Skip to content

fix: Use native CA certificates #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickLarsenNZ merged 5 commits into from
Feb 4, 2025
Merged

fix: Use native CA certificates #351

NickLarsenNZ merged 5 commits into from
Feb 4, 2025

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jan 31, 2025 •
edited
Loading

Description

Use rustls-native-certs so that stackablectl can be used in environments with internal PKI.

This is needed in the following cases:

  • Internal mirrors of helm charts or stacks/demos signed by an internal CA.
  • Firewalls that intercept HTTPS traffic.

@NickLarsenNZ
fix: Use native CA certificates
124d79f
@NickLarsenNZ
chore(stackablectl): update changelog
96401fd
@NickLarsenNZ
chore: set pre-release version
d2ff9e0 
This is not usually done at this stage, but we want to produce a pre-release for testing, and it should not show the stable version.
@NickLarsenNZ
chore: Set PR number in the Changelog
cbfd355
@NickLarsenNZ NickLarsenNZ self-assigned this Feb 3, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review February 3, 2025 10:13
Techassi
Techassi reviewed Feb 3, 2025
View reviewed changes
@Techassi
Copy link
Member

Techassi commented Feb 3, 2025

The change itself is approved. We just need to clarify the above question.

@NickLarsenNZ NickLarsenNZ requested a review from Techassi February 3, 2025 14:42
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 70049ca Feb 4, 2025
16 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/use-native-roots branch February 4, 2025 13:16
@Techassi Techassi linked an issue Feb 5, 2025 that may be closed by this pull request
Support custom system-provided TLS truststores #350
Closed
@Techassi Techassi mentioned this pull request Feb 5, 2025
Closed
@Techassi Techassi mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support custom system-provided TLS truststores

3 participants

@NickLarsenNZ @Techassi