feat: Select versions of demos & stacks #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the unused --offline flag. Feel free to ignore that.
Techassi
requested changes
Dec 5, 2024
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
Mostly lgtm, a few smaller comments.
Also, please add changelog entries regarding the --offline removal, the addition of --release and make sure to fix pre-commit and rust-doc errors.
sbernauer
reviewed
Dec 5, 2024
Co-authored-by: Techassi <git@techassi.dev>
This add a Deref impl for the List type, which removed the need to call .inner() to retrieve the IndexMap. Instead IndexMap's methods can now be used by deref'ing. Also, the SpecIter trait now consumes self, which removes two superflous calls to .clone().
Techassi
approved these changes
Dec 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* wip: Add release selection to demo command Also removes the unused --offline flag. Feel free to ignore that. * add --release arg to stacks * Update rust/stackablectl/src/cmds/demo.rs Co-authored-by: Techassi <git@techassi.dev> * refactor 'latest_release' and address PR feedback * refactor 'latest_release' and address PR feedback * add changelog entry * add changelog entry * chore: Restructure changelog * refactor: Simplify List type This add a Deref impl for the List type, which removed the need to call .inner() to retrieve the IndexMap. Instead IndexMap's methods can now be used by deref'ing. Also, the SpecIter trait now consumes self, which removes two superflous calls to .clone(). * chore: Remove unused regex dependency --------- Co-authored-by: Techassi <git@techassi.dev>
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #310.
--release <release>argument todemoandstackcommands which allows installing from a specific release branch.--releaseis not specified the latest release is used.--release devinstall from main branch.Definition of Done Checklist