Skip to content

Enable kube proxy support #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nightkr merged 3 commits into from
Nov 20, 2024
Merged

Enable kube proxy support #328

nightkr merged 3 commits into from
Nov 20, 2024

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Nov 5, 2024

Description

See https://stackable-workspace.slack.com/archives/C02FZ581UCD/p1730720863001449, https://stackable-workspace.slack.com/archives/C02FZ581UCD/p1730795983056059.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr requested review from a team, Jimvin and Techassi November 5, 2024 09:40
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ self-requested a review November 20, 2024 15:51
NickLarsenNZ
NickLarsenNZ approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 26c850c Nov 20, 2024
17 checks passed
@nightkr nightkr deleted the feature/kube-proxy branch November 20, 2024 15:53
This was referenced Nov 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@Jimvin Jimvin Awaiting requested review from Jimvin

@Techassi Techassi Awaiting requested review from Techassi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nightkr @NickLarsenNZ @Techassi