helm installs: uninstall and install chart instead of upgrade due to helmv3 force changes

Author: xeniape

rust/helm-sys/go-helm-wrapper/main.go

@@ -58,30 +58,6 @@ func go_install_helm_release(releaseName *C.char, chartName *C.char, chartVersio
 	return C.CString("")
 }
 
-//export go_upgrade_or_install_helm_release
-func go_upgrade_or_install_helm_release(releaseName *C.char, chartName *C.char, chartVersion *C.char, valuesYaml *C.char, namespace *C.char, suppressOutput bool) *C.char {
-	helmClient := getHelmClient(namespace, suppressOutput)
-
-	timeout, _ := time.ParseDuration("20m")
-	chartSpec := gohelm.ChartSpec{
-		ReleaseName: C.GoString(releaseName),
-		ChartName:   C.GoString(chartName),
-		Version:     C.GoString(chartVersion),
-		ValuesYaml:  C.GoString(valuesYaml),
-		Namespace:   C.GoString(namespace),
-		UpgradeCRDs: true,
-		Wait:        true,
-		Timeout:     timeout,
-		Force:       true,
-	}
-
-	if _, err := helmClient.InstallOrUpgradeChart(context.Background(), &chartSpec, nil); err != nil {
-		return C.CString(fmt.Sprintf("%s%s", HELM_ERROR_PREFIX, err))
-	}
-
-	return C.CString("")
-}
-
 //export go_uninstall_helm_release
 func go_uninstall_helm_release(releaseName *C.char, namespace *C.char, suppressOutput bool) *C.char {
 	helmClient := getHelmClient(namespace, suppressOutput)

rust/helm-sys/src/lib.rs

@@ -37,34 +37,6 @@ pub fn install_helm_release(
     }
 }
 
-pub fn upgrade_or_install_helm_release(
-    release_name: &str,
-    chart_name: &str,
-    chart_version: &str,
-    values_yaml: &str,
-    namespace: &str,
-    suppress_output: bool,
-) -> String {
-    let release_name = CString::new(release_name).unwrap();
-    let chart_name = CString::new(chart_name).unwrap();
-    let chart_version = CString::new(chart_version).unwrap();
-    let values_yaml = CString::new(values_yaml).unwrap();
-    let namespace = CString::new(namespace).unwrap();
-
-    unsafe {
-        let c = go_upgrade_or_install_helm_release(
-            release_name.as_ptr() as *mut c_char,
-            chart_name.as_ptr() as *mut c_char,
-            chart_version.as_ptr() as *mut c_char,
-            values_yaml.as_ptr() as *mut c_char,
-            namespace.as_ptr() as *mut c_char,
-            suppress_output as u8,
-        );
-
-        cstr_ptr_to_string(c)
-    }
-}
-
 pub fn uninstall_helm_release(
     release_name: &str,
     namespace: &str,

rust/stackable-cockpit/src/helm.rs

@@ -371,7 +371,9 @@ fn upgrade_release(
     namespace: &str,
     suppress_output: bool,
 ) -> Result<(), Error> {
-    let result = helm_sys::upgrade_or_install_helm_release(
+    uninstall_release(release_name, namespace, suppress_output)?;
+
+    let result = helm_sys::install_helm_release(
         release_name,
         chart_name,
         chart_version,