ignore jobs on reapply, merge instead of apply for existing objects

Author: xeniape

rust/stackable-cockpit/src/utils/k8s/client.rs

@@ -15,7 +15,7 @@ use snafu::{OptionExt, ResultExt, Snafu};
 use stackable_operator::{commons::listener::Listener, kvp::Labels};
 use tokio::sync::RwLock;
 use tracing::{Span, info, instrument};
-use tracing_indicatif::span_ext::IndicatifSpanExt as _;
+use tracing_indicatif::{indicatif_println, span_ext::IndicatifSpanExt as _};
 
 #[cfg(doc)]
 use crate::utils::k8s::ListParamsExt;
@@ -114,6 +114,7 @@ impl Client {
 
         // TODO (Techassi): Impl IntoIterator for Labels
         let labels: BTreeMap<String, String> = labels.into();
+        let mut failed_manifests = Vec::new();
 
         for manifest in serde_yaml::Deserializer::from_str(manifests) {
             let mut object = DynamicObject::deserialize(manifest).context(DeserializeYamlSnafu)?;
@@ -144,13 +145,54 @@ impl Client {
                 }
             };
 
-            api.patch(
-                &object.name_any(),
-                &PatchParams::apply("stackablectl"),
-                &Patch::Apply(object),
-            )
-            .await
-            .context(KubeClientPatchSnafu)?;
+            if let Some(existing_object) = api
+                .get_opt(&object.name_any())
+                .await
+                .context(KubeClientFetchSnafu)?
+            {
+                object.metadata.resource_version = existing_object.resource_version();
+
+                match api
+                    .patch(
+                        &object.name_any(),
+                        &PatchParams::apply("stackablectl"),
+                        &Patch::Merge(object.clone()),
+                    )
+                    .await
+                {
+                    Ok(result) => result,
+                    Err(e) => {
+                        // If re-applying a Job fails due to immutability, print out the failed manifests instead of erroring out,
+                        // so the user can decide if the existing Job needs a deletion and recreation
+                        if resource.kind == *"Job" && e.to_string().contains("field is immutable") {
+                            failed_manifests.push(format!(
+                                "{kind} {object_name}",
+                                kind = resource.kind,
+                                object_name = object.name_any().clone()
+                            ));
+                            object
+                        } else {
+                            indicatif_println!(
+                                "{object_name} {object:?}",
+                                object_name = &object.name_any()
+                            );
+                            return Err(e).context(KubeClientPatchSnafu);
+                        }
+                    }
+                };
+            } else {
+                api.patch(
+                    &object.name_any(),
+                    &PatchParams::apply("stackablectl"),
+                    &Patch::Apply(object.clone()),
+                )
+                .await
+                .context(KubeClientPatchSnafu)?;
+            }
+        }
+
+        if !failed_manifests.is_empty() {
+            indicatif_println!("Failed manifests due to immutability: {failed_manifests:?}");
         }
 
         Ok(())