Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 22, 2025

Description

Update OLM deployer to work with the current op structure.

Tested with OLM manifests from: stackabletech/openshift-certified-operators#20 which were generated from the Helm manifests in this branch.

🟢 Kuttl tests on OpenShift 4.17:

# Skip installing the secret op since it's been already installed by OLM
$ ./scripts/run-tests --test-suite openshift --skip-operator secret
...
--- PASS: kuttl (173.09s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cert-manager-tls_openshift-true (62.36s)
        --- PASS: kuttl/harness/tls_openshift-true_rsa-key-length-2048_custom-secret-names-False (76.31s)
        --- PASS: kuttl/harness/tls_openshift-true_rsa-key-length-3072_custom-secret-names-True (17.99s)
        --- PASS: kuttl/harness/tls_openshift-true_rsa-key-length-3072_custom-secret-names-False (16.88s)
        --- PASS: kuttl/harness/tls_openshift-true_rsa-key-length-2048_custom-secret-names-True (27.88s)
        --- PASS: kuttl/harness/tls-truststore_openshift-true_truststore-target-kind-ConfigMap (7.53s)
        --- PASS: kuttl/harness/tls-truststore_openshift-true_truststore-target-kind-Secret (8.36s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-true (71.32s)
        --- PASS: kuttl/harness/listener_openshift-true (31.71s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes) passed
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 22, 2025
@razvan razvan mentioned this pull request Oct 22, 2025
20 tasks
@razvan razvan marked this pull request as ready for review October 23, 2025 13:38
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Oct 23, 2025
@razvan razvan requested a review from a team October 23, 2025 13:39
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 23, 2025 14:08
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 23, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I ran the tests with the deployed bundle, but also with the operator deployed via stackablectl: all good!

@razvan razvan enabled auto-merge October 23, 2025 15:22
@razvan razvan added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit e60e967 Oct 23, 2025
17 checks passed
@razvan razvan deleted the fix/olm-deployer-2 branch October 23, 2025 15:49
@razvan razvan moved this from Development: In Review to Development: Done in Stackable Engineering Oct 23, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants