Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 23, 2025

Description

Previously, Kerberos principals were only provisioned for hostnames. This PR also adds support for IP addresses, since we default to using IP addresses for NodePort listeners (vs the old node scope, which used hostnames).

Fixes stackabletech/kafka-operator#812.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr nightkr requested review from a team and siegfriedweber January 23, 2025 13:41
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test looks good, thanks!
Can you please add a changelog entry?

@nightkr
Copy link
Contributor Author

nightkr commented Jan 23, 2025

@sbernauer Like 58b5272, you mean? :P

@nightkr nightkr requested a review from sbernauer January 23, 2025 13:52
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were quicker ;)

@nightkr nightkr enabled auto-merge January 23, 2025 13:52
@nightkr nightkr added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit add89d9 Jan 23, 2025
17 checks passed
@nightkr nightkr deleted the feature/kerberos-ip branch January 23, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kerberos does not work when choosing an external bootstrapListenerClass

3 participants