Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 23, 2025

Description

This reverts the FQDNization-by-default from 0.84.0

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

This reverts the FQDNization-by-default from 0.84.0
@nightkr nightkr requested a review from a team January 23, 2025 12:00
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 5e73a95 Jan 23, 2025
17 checks passed
@nightkr nightkr deleted the chore/op-rs-0.84.1 branch January 23, 2025 12:40
nightkr added a commit that referenced this pull request Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
* Provision principals for IP addresses

* Add nodeport IP listener volume test

* Changelog

* Remove FQDNization from changelog

It was reverted in #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants