Skip to content

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Dec 11, 2024

Description

  • Helm chart: The secret migration job can be omitted via Helm values.
  • Helm chart: The tag of the tools image used for the secret migration job can be changed in the Helm values and defaults to the current SDP version instead of 24.7.0.

part of #477

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber requested a review from a team December 11, 2024 11:20
@siegfriedweber siegfriedweber self-assigned this Dec 11, 2024
@siegfriedweber
Copy link
Member Author

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siegfriedweber siegfriedweber added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 560d1f8 Dec 12, 2024
17 checks passed
@siegfriedweber siegfriedweber deleted the fix_helm/config-options-for-secret-migration-job branch December 12, 2024 13:22
siegfriedweber added a commit that referenced this pull request Dec 13, 2024
* fix(helm): Add configuration options for the secret migration job

* fix(helm): Default the tools image to 1.0.0-stackable24.11.0
NickLarsenNZ pushed a commit that referenced this pull request Dec 13, 2024
* release 24.11.1-rc2

Signed-off-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>

* fix(helm): Add configuration options for the secret migration job (#536)

* fix(helm): Add configuration options for the secret migration job

* fix(helm): Default the tools image to 1.0.0-stackable24.11.0

---------

Signed-off-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@lfrancke
Copy link
Member

I think it'd be useful to have a release note snippet for this.

@siegfriedweber
Copy link
Member Author

Release Notes

Secret operator

Helm chart: The secret migration job required for upgrading from SDP 24.3 to 24.7, can now be omitted by setting the Helm value secretMigrationJob.enabled to false.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-request release/24.11.1 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants