Skip to content

Add support for specifying cert-manager key lengths #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nightkr merged 6 commits into from
Dec 9, 2024
Merged

Add support for specifying cert-manager key lengths #528

nightkr merged 6 commits into from
Dec 9, 2024

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Nov 27, 2024

Description

Fixes #527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr nightkr requested a review from a team November 27, 2024 16:05
sbernauer
sbernauer previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRD change and code LGTM
The CRD is 1:1 the same as for the autoTls backend

@nightkr
Copy link
Contributor Author

nightkr commented Dec 2, 2024

Voting comment, as usual:
👍 for Yes
👎 for No

@sbernauer
Copy link
Member

sbernauer commented Dec 9, 2024

Accepted

@nightkr nightkr enabled auto-merge December 9, 2024 08:26
@nightkr nightkr disabled auto-merge December 9, 2024 08:26
@nightkr nightkr requested a review from sbernauer December 9, 2024 08:56
@nightkr nightkr added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 0332dab Dec 9, 2024
17 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Dec 9, 2024
@nightkr
Add support for specifying cert-manager key lengths (#528)
0332dab 
* Add key length config to cert-manager integration

* Docs

* Changelog

* Update CRD

* Update dependencies
@nightkr nightkr deleted the feature/cert-manager-key-length branch December 9, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@nightkr nightkr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify key length for cert-manager certificates

3 participants

@nightkr @sbernauer