chore!: Enable and fix a few pedantic and nursery clippy lints#1186
Draft
chore!: Enable and fix a few pedantic and nursery clippy lints#1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See
Cargo.tomlon what lints are now enabled. They apply to all workspace members.Some lints we want to enable in the future, but for now I'm ignoring them, as the PR is big enough already with the easy ones.
E.g. we need to think about many possible number truncations.
I suggest reviewing the commits one by one. Some lints have been auto-corrected (
--fix), some manually.Definition of Done Checklist
Author
Reviewer
Acceptance