Skip to content

fix(stackable-telemetry): Only derive clap::ValueEnum if the clap feature is enabled #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickLarsenNZ merged 2 commits into from
May 8, 2025
Merged

fix(stackable-telemetry): Only derive clap::ValueEnum if the clap feature is enabled #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5273f5e
fix(stackable-telemetry): Only derive clap::ValueEnum if the clap fea…
NickLarsenNZ May 8, 2025
9c33146
chore(stackable-telemetry): Update changelog
NickLarsenNZ May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/stackable-telemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ All notable changes to this project will be documented in this file.

- Bump `opentelemetry` and related crates to `0.29.x` and `tracing-opentelemetry` to `0.30.0` ([#1021]).

### Fixed

- Only derive `clap::ValueEnum` if the `clap` feature is enabled ([#1026]).

[#1021]: https://github.com/stackabletech/operator-rs/pull/1021
[#1026]: https://github.com/stackabletech/operator-rs/pull/1026

## [0.6.0] - 2025-04-14

Expand Down
5 changes: 2 additions & 3 deletions crates/stackable-telemetry/src/tracing/settings/console_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ pub enum ConsoleLogSettings {
/// Console subscriber log event output formats.
///
/// Currently, only [Plain][Format::Plain] is supported.
#[derive(
Clone, Debug, Default, Eq, PartialEq, strum::EnumString, strum::Display, clap::ValueEnum,
)]
#[derive(Clone, Debug, Default, Eq, PartialEq, strum::EnumString, strum::Display)]
#[cfg_attr(feature = "clap", derive(clap::ValueEnum))]
#[strum(serialize_all = "snake_case")]
pub enum Format {
/// Use the plain unstructured log output.
Expand Down