-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: TLS support #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TLS support #774
Conversation
f11e0c8 to
7d892ac
Compare
7d892ac to
a457de3
Compare
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Im not sure about testing only https in smoke since the default is http?
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Yeah, probably right. I changed the smoke test to test both http and https now: ee64394 |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Part of #581
This adds TLS support to OPA.
CRD change was approved in #769
The smoke test was adapted to test OPA with TLS.
Example usage with Trino: stackabletech/trino-operator#812
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker