Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Oct 29, 2025

Description

Part of #581

This adds TLS support to OPA.

CRD change was approved in #769

The smoke test was adapted to test OPA with TLS.

Example usage with Trino: stackabletech/trino-operator#812

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti dervoeti force-pushed the feat/support-tls branch 2 times, most recently from f11e0c8 to 7d892ac Compare October 29, 2025 20:26
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Oct 29, 2025
@dervoeti dervoeti self-assigned this Oct 29, 2025
@maltesander maltesander self-requested a review October 30, 2025 14:26
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 30, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Im not sure about testing only https in smoke since the default is http?

dervoeti and others added 7 commits October 31, 2025 14:05
@dervoeti
Copy link
Member Author

dervoeti commented Nov 3, 2025

Nice! Im not sure about testing only https in smoke since the default is http?

Yeah, probably right. I changed the smoke test to test both http and https now: ee64394

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dervoeti dervoeti added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit c0fdf99 Nov 3, 2025
17 checks passed
@dervoeti dervoeti deleted the feat/support-tls branch November 3, 2025 16:39
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering Nov 5, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Nov 11, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants