-
-
Notifications
You must be signed in to change notification settings - Fork 4
docs: Document how to ship OTEL traces #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably hold off this one until we support config overrides.
Apologies if this had already been discussed and agreed on.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
|
I see your point, on the other hand I don't think we will get configOverrides in the next year or two 🙈 |
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* docs: Document how to ship OTEL traces * Update docs/modules/opa/pages/usage-guide/OpenTelemetry.adoc Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> * Update docs/modules/opa/pages/usage-guide/OpenTelemetry.adoc * mention GitHub issue --------- Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker