Skip to content

fix: Pass KUBERNETES_NODE_NAME to product sidecars and other bugs #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 3 commits into from
Jul 11, 2025
Merged

fix: Pass KUBERNETES_NODE_NAME to product sidecars and other bugs #744

sbernauer merged 3 commits into from
Jul 11, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 11, 2025

Description

Should fix the kuttl tests.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jul 11, 2025
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Jul 11, 2025
@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jul 11, 2025
@razvan razvan self-requested a review July 11, 2025 13:39
NickLarsenNZ
NickLarsenNZ approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer enabled auto-merge July 11, 2025 13:46
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jul 11, 2025
@sbernauer sbernauer disabled auto-merge July 11, 2025 13:47
@sbernauer sbernauer enabled auto-merge July 11, 2025 13:58
@sbernauer sbernauer added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit d3e23ec Jul 11, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/k8s-node-name branch July 11, 2025 14:22
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 14, 2025
sbernauer
sbernauer commented Jul 17, 2025
View reviewed changes
deploy/helm/opa-operator/templates/roles.yaml
- patch
verbs:
- create
- patch
Copy link
Member Author

@sbernauer sbernauer Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker to check that all other operators have this RBAC permission

dervoeti pushed a commit that referenced this pull request Oct 29, 2025
@sbernauer @dervoeti
fix: Pass KUBERNETES_NODE_NAME to product sidecars and other bugs (#744)
553b40d 
* fix: Pass KUBERNETES_NODE_NAME to product sidecars and other bugs

* Unneccesary constification

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@razvan razvan Awaiting requested review from razvan

Assignees

@sbernauer sbernauer

Labels

release/25.7.0 type/bug

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @NickLarsenNZ