Skip to content

Conversation

@dervoeti
Copy link
Member

Description

Sometimes it takes longer than 5 minutes for all the OPA pods to be ready in our weekly tests.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Jun 30, 2025
@dervoeti dervoeti self-assigned this Jun 30, 2025
commands:
- script: kubectl -n $NAMESPACE rollout status daemonset test-opa-server-default --timeout 301s
- script: kubectl -n $NAMESPACE wait --for=condition=available opaclusters.opa.stackable.tech/test-opa --timeout 301s
- script: kubectl -n $NAMESPACE rollout status daemonset test-opa-server-default --timeout 600s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing there was some reason the timeouts were longer by one second on these commands, but if that isn't recorded in a comment, I'm happy for us to re-learn and them document why.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 30, 2025
@NickLarsenNZ
Copy link
Member

I'll merge this because @dervoeti is away

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 948e3a2 Jul 1, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/test-timeouts branch July 1, 2025 06:12
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 2, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants