Skip to content

Use service scope for user-info-fetcher AD kerberos keytab #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nightkr merged 7 commits into from
Mar 20, 2025
Merged

Use service scope for user-info-fetcher AD kerberos keytab #698

nightkr merged 7 commits into from
Mar 20, 2025

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Mar 19, 2025 •
edited
Loading

Description

Fixes #680

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [X] Helm chart can be installed and deployed operator works
- [X] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr nightkr requested review from a team and soenkeliebau March 19, 2025 09:50
sbernauer
sbernauer reviewed Mar 19, 2025
View reviewed changes
@nightkr nightkr requested a review from sbernauer March 20, 2025 11:19
sbernauer
sbernauer previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

@nightkr nightkr requested a review from sbernauer March 20, 2025 12:36
@nightkr
Copy link
Contributor Author

nightkr commented Mar 20, 2025

Sorry, forgot to run formatting.

@nightkr nightkr enabled auto-merge March 20, 2025 12:37
@nightkr nightkr added this pull request to the merge queue Mar 20, 2025
@sbernauer sbernauer changed the title Use service scope for user-info-fetcher AD kerberos keytab fix: Use service scope for user-info-fetcher AD kerberos keytab Mar 20, 2025
@sbernauer sbernauer changed the title fix: Use service scope for user-info-fetcher AD kerberos keytab Use service scope for user-info-fetcher AD kerberos keytab Mar 20, 2025
Merged via the queue into main with commit a30c479 Mar 20, 2025
17 checks passed
@nightkr nightkr deleted the bugfix/uif-ad-service-scope branch March 20, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

@soenkeliebau soenkeliebau Awaiting requested review from soenkeliebau

Assignees

No one assigned

Labels

release/25.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UserInfoFetcher Active Directory backend should use service scope for Kerberos

4 participants

@nightkr @sbernauer @soenkeliebau