Skip to content

Conversation

@Maleware
Copy link
Member

Description

Part of stackabletech/docker-images#969

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one OpaCluster ;)
Also the import rego.v1 should now be able to go 😅
Last but not least we need to update the supported versions list

diff --git a/docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc b/docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc
index 81cf504..6c9f90b 100644
--- a/docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc
+++ b/docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc
@@ -16,7 +16,7 @@ metadata:
   name: opa
 spec:
   image:
-    productVersion: 0.67.1
+    productVersion: 1.0.0
   clusterConfig:
     userInfo: # <1>
       backend:
@@ -132,8 +132,6 @@ For example, the following rule allows access for users in the `/admin` group:
 ----
 package test
 
-import rego.v1
-
 default allow := false
 
 allow if {
diff --git a/docs/modules/opa/partials/supported-versions.adoc b/docs/modules/opa/partials/supported-versions.adoc
index f7b0d81..f221808 100644
--- a/docs/modules/opa/partials/supported-versions.adoc
+++ b/docs/modules/opa/partials/supported-versions.adoc
@@ -2,5 +2,5 @@
 // This is a separate file, since it is used by both the direct OPA documentation, and the overarching
 // Stackable Platform documentation.
 
-* 0.67.1
-* 0.66.0 (deprecated)
+* 1.0.0
+* 0.67.1 (deprecated)

@Maleware
Copy link
Member Author

@sbernauer addressed some with b0ad785

Maleware and others added 4 commits January 24, 2025 10:58
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
sbernauer previously approved these changes Jan 24, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!
Please watch out for pre-commit

@Maleware Maleware enabled auto-merge January 24, 2025 11:59
@Maleware Maleware added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit d22031d Jan 24, 2025
17 checks passed
@Maleware Maleware deleted the chore/update-opa-to-1.0.0 branch January 24, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants