-
-
Notifications
You must be signed in to change notification settings - Fork 9
fix: Prevent missing certificates #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adwk67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - re-ran the two failed tests locally and both were 🟢 once the images had been pulled, so we probably have a timeout problem.
Suggestion: raise the timeout for the nifi cluster assert in the external-access test to 1200 (like the ldap test).
|
Raised the timeouts in 8c33023 |
adwk67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Part of stackabletech/issues#764.
The server TLS truststore handling was actually fine and left as-is. Only LDAP and OIDC ca cert handling was affected.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker