fix: Add metrics Service SAN to NiFis certificate #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeniape
approved these changes
Jul 17, 2025
Member
|
Updated the description about PodIPs being in the list of SANs and linking to the issue related to that. So scraping metrics from PodIPs is still not possible. |
Member
Author
|
Thanks for updating the description! |
sbernauer
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Subject Alternative Names: simple-nifi-reporting-task.default.svc.cluster.local, IP Address:172.20.0.2, simple-nifi-node-default-headless.default.svc.cluster.local, simple-nifi-node-default-0.simple-nifi-node-default-headless.default.svc.cluster.localAfter
Subject Alternative Names: simple-nifi-node-default-metrics.default.svc.cluster.local, simple-nifi-reporting-task.default.svc.cluster.local, IP Address:172.20.0.2, simple-nifi-node-default-headless.default.svc.cluster.local, simple-nifi-node-default-0.simple-nifi-node-default-headless.default.svc.cluster.localNote the
simple-nifi-node-default-metrics.default.svc.cluster.localadditionWe can now curl the metrics (cert should match, no SNI check failure)
curl -k https://simple-nifi-node-default-metrics.default.svc.cluster.local:8443/nifi-api/flow/metrics/prometheusworks as in returns a 401 (excpected)Please note that this is a load-balanced service, users probably want to use a ServiceMonitor to scrape all Pods individually. AFAIK Prometheus collects the list of Pods of the Service and scrapes them by their Pod IP,
which is also in the list of SANs :)-> stackabletech/secret-operator#620