Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@adwk67
Copy link
Member

adwk67 commented Nov 11, 2024

Currently testing this PR on openshift and test_nifi_metrics.py in e.g. the upgrade test doesn't detect any metrics.

Copy link
Member Author

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@sbernauer
Copy link
Member Author

Currently testing this PR on openshift and test_nifi_metrics.py in e.g. the upgrade test doesn't detect any metrics.

Good catch, the upgrade test probably also needs the same if clause

Copy link
Member Author

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small doc nits, LGTM otherwise (I can't approve)

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander maltesander added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 70439e8 Nov 12, 2024
15 of 16 checks passed
@maltesander maltesander deleted the fix/avoid-reporting-task-for-2.0.0 branch November 12, 2024 10:15
@lfrancke
Copy link
Member

Please include a link to the docs

@sbernauer
Copy link
Member Author

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants