Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 7, 2025

Description

Part of stackabletech/issues#770
Needs stackabletech/operator-rs#1105

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release notes are on parent issue

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

sbernauer and others added 4 commits October 13, 2025 10:04
@sbernauer sbernauer changed the title feat!: Make NodePort stickiness configurable feat!: Make NodePort pinning configurable Oct 20, 2025
@sbernauer sbernauer self-assigned this Oct 20, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 20, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, read the last few commits since my last review comments.

@sbernauer sbernauer enabled auto-merge October 22, 2025 06:34
@sbernauer sbernauer added this pull request to the merge queue Oct 22, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Oct 22, 2025
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Oct 22, 2025
@sbernauer sbernauer moved this from Development: Done to Development: In Review in Stackable Engineering Oct 22, 2025
@sbernauer
Copy link
Member Author

--- PASS: kuttl (268.41s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-false_loadbalancer-allocatenodeports-true (7.37s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-Hostname (242.51s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-IP (235.53s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-false_loadbalancer-allocatenodeports-false (7.35s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-HostnameConservative (25.50s)
PASS

@sbernauer sbernauer added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 9f566ff Oct 22, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/configurable-stickiness branch October 22, 2025 06:47
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 22, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 24, 2025
@lfrancke
Copy link
Member

Release notes are on the parent

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants