Skip to content

fix: Lot of configs missing for middleManagers #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 3 commits into from
Jul 23, 2025
Merged

fix: Lot of configs missing for middleManagers #740

sbernauer merged 3 commits into from
Jul 23, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 22, 2025 •
edited
Loading

Description

product-config strikes again...
I noticed I was able to scrape all Pods except the middleManagers. Looking into the config I noticed that like 30% is missing...

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jul 22, 2025
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Jul 22, 2025
@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jul 22, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If this is going into the release it needs a PR and testing.

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 22, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Jul 22, 2025

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/59/

@sbernauer sbernauer enabled auto-merge July 23, 2025 05:27
@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.7.0 and removed scheduled-for/25.7.0 labels Jul 23, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Jul 23, 2025

Release notes

Fix lot of configuration properties missing on the middleManager roles

@sbernauer sbernauer added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit a18e7c8 Jul 23, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/middle-manager-properties branch July 23, 2025 05:31
sbernauer added a commit that referenced this pull request Jul 23, 2025
@sbernauer
fix: Lot of configs missing for middleManagers (#740)
efe9785 
* fix: Lot of configs missing for middleManagers

* changelog

* linter
@sbernauer sbernauer mentioned this pull request Jul 23, 2025
Merged
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 23, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@sbernauer sbernauer

Labels

release/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @NickLarsenNZ