Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Backport the Kafka offset fix trinodb/trino#26789 (merge into Trino 478) to Trino 477.

Requested in https://stackable-workspace.slack.com/archives/C06H1D6FCJD/p1767705763731589

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@sbernauer sbernauer self-assigned this Jan 7, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jan 7, 2026
maltesander
maltesander previously approved these changes Jan 7, 2026
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changelog missing!

@sbernauer
Copy link
Member Author

Thanks! Changelog pushed

@sbernauer sbernauer requested a review from maltesander January 7, 2026 16:16
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 5acac8d Jan 8, 2026
3 checks passed
@sbernauer sbernauer deleted the chore/trino-kafka-backport branch January 8, 2026 07:54
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jan 8, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants