fix: Enable Demo/Stack installations in non-default namespaces#374
Merged
fix: Enable Demo/Stack installations in non-default namespaces#374
Conversation
xeniape
changed the title
sbernauer
reviewed
Mar 11, 2026
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Looks like it's going into a good direction, thanks!
11 tasks
Member
Author
|
Only merge this one after stackabletech/stackable-cockpit#429 is merged (because of the |
11 tasks
sbernauer
approved these changes
Mar 30, 2026
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
I think I would have went with files called foo.yaml.j2 instead of this comment trick but anyway xD
It didn't test installing the demos (I assume that exactly what you did), but the changes LGTM, thanks!
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/stackable-cockpit#187
This PR parameterizes places where
defaultwas hard-coded previously, enabling demo/stack installation in non-default namesplaces. Adds demo/stack labels. Fixes some minor broken demos.