feat: Jupyterhub with keycloak, spark and s3#155
Merged
Conversation
adwk67
changed the title
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
requested changes
Mar 3, 2025
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
Worked smoothly, first batch of comments, will do some more testing!
sbernauer
reviewed
Mar 3, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Thanks for the nice demo!
One general remark, what is the reason that HDFS was added? I feel like this over-complicates the demo a bit, S3 would be sufficient from my point of view.
Review comments. Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Member
Author
Yes, I think I agree - I'll take it out (we have it included in one of the other jupyterhub demos anyway). |
Member
|
Thanks! |
sbernauer
reviewed
Mar 3, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback!
Member
Author
Done: 80bd2c6 |
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
maltesander
reviewed
Mar 3, 2025
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demo illustrates JupyterHub usage with Keycloak. Various configuration settings will be explained in more detail in the main documentation. See stackabletech/documentation#715.