Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,17 @@
- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
- Please make sure all these things are done and tick the boxes

```[tasklist]
# Author
- [ ] Changes are OpenShift compatible
- [ ] Integration tests passed (for non trivial changes)
```

```[tasklist]
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
```

```[tasklist]
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
```
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Stackable Build Pipeline

on:

Check warning on line 4 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

4:1 [truthy] truthy value should be one of [false, true]
push:
branches:
- main
Expand All @@ -17,7 +17,7 @@
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: "0"
CARGO_PROFILE_DEV_DEBUG: "0"
RUST_TOOLCHAIN_VERSION: "1.82.0"
RUST_TOOLCHAIN_VERSION: "1.85.0"
RUSTFLAGS: "-D warnings"
RUSTDOCFLAGS: "-D warnings"
RUST_LOG: "info"
Expand All @@ -30,11 +30,11 @@
env:
RUSTC_BOOTSTRAP: 1
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Check warning on line 33 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

33:73 [comments] too few spaces before comment: expected 2
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5

Check failure on line 37 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

37:81 [line-length] line too long (83 > 80 characters)

Check warning on line 37 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

37:76 [comments] too few spaces before comment: expected 2
with:
key: udeps
- run: cargo install --locked cargo-udeps@0.1.50
Expand All @@ -53,8 +53,8 @@
continue-on-error: ${{ matrix.checks == 'advisories' }}

steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Check warning on line 56 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

56:73 [comments] too few spaces before comment: expected 2
- uses: EmbarkStudios/cargo-deny-action@e2f4ede4a4e60ea15ff31bc0647485d80c66cfba # v2.0.4

Check failure on line 57 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

57:81 [line-length] line too long (95 > 80 characters)

Check warning on line 57 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

57:88 [comments] too few spaces before comment: expected 2
with:
command: check ${{ matrix.checks }}

Expand All @@ -62,12 +62,12 @@
name: Run Rustfmt
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Check warning on line 65 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

65:73 [comments] too few spaces before comment: expected 2
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
components: rustfmt
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5

Check failure on line 70 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

70:81 [line-length] line too long (83 > 80 characters)

Check warning on line 70 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

70:76 [comments] too few spaces before comment: expected 2
with:
key: fmt
- run: cargo fmt --all -- --check
Expand All @@ -79,22 +79,22 @@
- name: Install host dependencies
run: |
sudo apt-get update
sudo apt-get install protobuf-compiler krb5-user libkrb5-dev libclang-dev liblzma-dev libssl-dev pkg-config

Check failure on line 82 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

82:81 [line-length] line too long (117 > 80 characters)
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
components: clippy
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5

Check failure on line 90 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

90:81 [line-length] line too long (83 > 80 characters)
with:
key: clippy
- name: Run clippy action to produce annotations
# NOTE (@Techassi): This action might get a new release soon, because it
# currently uses Node 16, which is deprecated in the next few months by
# GitHub. See https://github.com/giraffate/clippy-action/pull/87
uses: giraffate/clippy-action@13b9d32482f25d29ead141b79e7e04e7900281e0 # v1.0.1

Check failure on line 97 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

97:81 [line-length] line too long (87 > 80 characters)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: env.GITHUB_TOKEN != null && github.event.pull_request.draft == false
Expand All @@ -112,12 +112,12 @@
name: Run RustDoc
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
components: rustfmt
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5

Check failure on line 120 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

120:81 [line-length] line too long (83 > 80 characters)
with:
key: doc
- run: cargo doc --document-private-items
Expand All @@ -130,15 +130,15 @@
- run_rustdoc
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
# rust-src is required for trybuild stderr output comparison to work
# for our cases.
# See: https://github.com/dtolnay/trybuild/issues/236#issuecomment-1620950759

Check failure on line 139 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

139:81 [line-length] line too long (87 > 80 characters)
components: rust-src
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5

Check failure on line 141 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / pre-commit

141:81 [line-length] line too long (83 > 80 characters)
with:
key: test
- run: cargo test --all-features
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily_security.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Security audit

on:

Check warning on line 4 in .github/workflows/daily_security.yml

View workflow job for this annotation

GitHub Actions / pre-commit

4:1 [truthy] truthy value should be one of [false, true]
schedule:
- cron: '15 4 * * *'
workflow_dispatch:
Expand All @@ -10,7 +10,7 @@
audit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Check warning on line 13 in .github/workflows/daily_security.yml

View workflow job for this annotation

GitHub Actions / pre-commit

13:73 [comments] too few spaces before comment: expected 2
- uses: rustsec/audit-check@69366f33c96575abad1ee0dba8212993eecbe998 # v2.0.0

Check failure on line 14 in .github/workflows/daily_security.yml

View workflow job for this annotation

GitHub Actions / pre-commit

14:81 [line-length] line too long (83 > 80 characters)

Check warning on line 14 in .github/workflows/daily_security.yml

View workflow job for this annotation

GitHub Actions / pre-commit

14:76 [comments] too few spaces before comment: expected 2
with:
token: ${{ secrets.GITHUB_TOKEN }}
7 changes: 3 additions & 4 deletions .github/workflows/pr_pre-commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@ on:

env:
CARGO_TERM_COLOR: always
RUST_TOOLCHAIN_VERSION: "1.82.0"
HADOLINT_VERSION: "v1.17.6"
RUST_TOOLCHAIN_VERSION: "1.85.0"

jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
- uses: stackabletech/actions/run-pre-commit@9bd13255f286e4b7a654617268abe1b2f37c3e0a # v0.3.0
- uses: stackabletech/actions/run-pre-commit@9aae2d1c14239021bfa33c041010f6fb7adec815 # v0.8.2
with:
rust: ${{ env.RUST_TOOLCHAIN_VERSION }}
# rust-src is required for trybuild stderr output comparison to work
Expand Down
9 changes: 5 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ default_language_version:

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: 2c9f875913ee60ca25ce70243dc24d5b6415598c # 4.6.0
rev: cef0300fd0fc4d2a87a85fa2093c6b283ea36f4b # 5.0.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
Expand All @@ -19,13 +19,14 @@ repos:
args: ["--all", "--", "--check"]
- id: clippy
args: ["--all-targets", "--", "-D", "warnings"]

- repo: https://github.com/adrienverge/yamllint
rev: 81e9f98ffd059efe8aa9c1b1a42e5cce61b640c6 # 1.35.1
rev: 79a6b2b1392eaf49cdd32ac4f14be1a809bbd8f7 # 1.37.1
hooks:
- id: yamllint

- repo: https://github.com/igorshubovych/markdownlint-cli
rev: f295829140d25717bc79368d3f966fc1f67a824f # 0.41.0
rev: 192ad822316c3a22fb3d3cc8aa6eafa0b8488360 # 0.45.0
hooks:
- id: markdownlint

Expand All @@ -36,7 +37,7 @@ repos:
args: ["--severity=info"]

- repo: https://github.com/rhysd/actionlint
rev: 62dc61a45fc95efe8c800af7a557ab0b9165d63b # 1.7.1
rev: 03d0035246f3e81f36aed592ffb4bebf33a03106 # 1.7.7
hooks:
- id: actionlint

Expand Down
Loading
Loading