Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 16, 2024

Description

After some discussion on Slack (https://stackable-workspace.slack.com/archives/C031A5Z9542/p1733999979523619), treating these as errors might be a bit harsh, given that containerdebug is "only" a diagnostics tool.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr requested review from a team and lfrancke December 16, 2024 10:52
@nightkr nightkr self-assigned this Dec 16, 2024
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo checks. Thanks for picking this up right away :)

@nightkr
Copy link
Contributor Author

nightkr commented Dec 16, 2024

Yeah the deny is a separate issue we should look into.

@nightkr nightkr added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 9875895 Dec 16, 2024
9 of 10 checks passed
@nightkr nightkr deleted the feature/dns-warning branch December 16, 2024 12:00
@lfrancke
Copy link
Member

I know I'm late here but considering it's a WARN it'd be helpful if we could give users some context.
Like "shit, there is a warning, what does it mean? is it bad for me? what can I do? What does it mean?"

Not sure if that's possible. Treat it as an idea.

@nightkr
Copy link
Contributor Author

nightkr commented Dec 17, 2024

Hmm..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants