Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Don't panic on invalid authorization config. Previously, a missing OPA ConfigMap would crash the operator

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jul 31, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 31, 2025
@sbernauer sbernauer requested a review from a team July 31, 2025 18:09
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sbernauer sbernauer added this pull request to the merge queue Aug 1, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Aug 1, 2025
Merged via the queue into main with commit 4d35655 Aug 1, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/invalid-authz-config-handling branch August 1, 2025 06:52
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 5, 2025
@lfrancke
Copy link
Member

Please add a release note snippet in the form "Previously, this went wrong. With this release, this was fixed in the following way."

@sbernauer
Copy link
Member Author

Release note

Previously, a missing OPA ConfigMap would crash the operator. With this release, we don't panic on an invalid authorization config

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 8, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants