Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Jun 18, 2025

Description

🟢 Tests (running mount-configmap and mount-gitsync to test the commonly-used scripts, as well as test-specific ones): https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/33/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-requested a review June 20, 2025 06:06
@maltesander maltesander moved this to Development: In Review in Stackable Engineering Jun 20, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of .webservers.config.listenerClass references left, e.g. in doc examples.
The mount-dags-gitsync fail for me (metrics check does not work).

@adwk67
Copy link
Member Author

adwk67 commented Jun 23, 2025

The mount-dags-gitsync fail for me (metrics check does not work).

That worked for me (although it took a while to pull the spark images). The service should be found OK:
image

@adwk67
Copy link
Member Author

adwk67 commented Jun 23, 2025

There are a couple of .webservers.config.listenerClass references left, e.g. in doc examples.

Changes in d83dfa0

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests work!

@adwk67
Copy link
Member Author

adwk67 commented Jun 24, 2025

LGTM if tests work!

🟢 Jenkins

@adwk67 adwk67 added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit c805f72 Jun 24, 2025
17 checks passed
@adwk67 adwk67 deleted the feat/role-level-listener branch June 24, 2025 14:21
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 24, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants