Skip to content

feat: Inject vector aggregator address as env into vector config #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickLarsenNZ merged 27 commits into from
Apr 9, 2025
Merged

feat: Inject vector aggregator address as env into vector config #600

NickLarsenNZ merged 27 commits into from
Apr 9, 2025

Conversation

@labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 1, 2025 •
edited
Loading

Description

  • Start watching ConfigMaps that are referenced in AirflowCluster spec and have not been created by the operator to restart Pods on changes to these ConfigMaps.
  • Inject vector aggregator address into the vector config using the env var VECTOR_AGGREGATOR_ADDRESS.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@labrenbe labrenbe mentioned this pull request Apr 1, 2025
Closed
@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in superset spec fix: Start watching configmaps that are referenced in airflow spec Apr 1, 2025
labrenbe and others added 12 commits April 1, 2025 16:18
@labrenbe labrenbe self-assigned this Apr 7, 2025
@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in airflow spec WIP: fix: Start watching configmaps that are referenced in airflow spec Apr 7, 2025
@labrenbe labrenbe changed the title WIP: fix: Start watching configmaps that are referenced in airflow spec fix: Start watching configmaps that are referenced in airflow spec Apr 8, 2025
@labrenbe labrenbe changed the title fix: Start watching configmaps that are referenced in airflow spec feat: Inject vector aggregator address as env into vector config Apr 8, 2025
@labrenbe labrenbe marked this pull request as ready for review April 9, 2025 11:19
NickLarsenNZ
NickLarsenNZ requested changes Apr 9, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, just a couple of suggestions.

labrenbe and others added 3 commits April 9, 2025 14:32
@labrenbe @NickLarsenNZ
Update rust/operator-binary/src/main.rs
82d7fb7 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@labrenbe
rename stores
c287a94
@labrenbe
run cargo update
cc27605
NickLarsenNZ
NickLarsenNZ requested changes Apr 9, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing around borrows

NickLarsenNZ
NickLarsenNZ requested changes Apr 9, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions around borrowing

labrenbe and others added 2 commits April 9, 2025 17:20
@labrenbe @NickLarsenNZ
Apply suggestions from code review
929c01d 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@NickLarsenNZ
chore: Formatting
62f26a2
@NickLarsenNZ NickLarsenNZ enabled auto-merge April 9, 2025 15:40
NickLarsenNZ
NickLarsenNZ approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit dff7fb2 Apr 9, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/reconcile-on-configmap branch April 9, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@labrenbe labrenbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@labrenbe @NickLarsenNZ @Techassi