Skip to content

feat: run containerdebug in the background #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
razvan merged 2 commits into from
Dec 10, 2024
Merged

feat: run containerdebug in the background #557

razvan merged 2 commits into from
Dec 10, 2024

Conversation

@razvan
Copy link
Member

@razvan razvan commented Dec 9, 2024

Description

Part of: stackabletech/issues#527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Dec 9, 2024
@razvan razvan requested a review from a team December 9, 2024 14:11
@razvan razvan mentioned this pull request Dec 9, 2024
Closed
nightkr
nightkr reviewed Dec 9, 2024
View reviewed changes
@razvan razvan added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 0e81184 Dec 10, 2024
16 of 17 checks passed
@razvan razvan deleted the feature/containerdebug branch December 10, 2024 08:14
@NickLarsenNZ NickLarsenNZ requested a review from Copilot April 7, 2025 08:26
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • tests/templates/kuttl/smoke/40-assert.yaml.j2: Language not supported

rust/crd/src/lib.rs
command.extend(Self::authentication_start_commands(auth_config));
command.extend(vec![
"prepare_signal_handlers".to_string(),
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format! macro is used with placeholders like {STACKABLE_LOG_DIR} but no arguments are provided. If you intend for these to be literal curly braces, consider escaping them by using double braces (e.g. "{{STACKABLE_LOG_DIR}}") or supply the required variables.

Suggested change
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
format!("CONTAINERDEBUG_LOG_DIRECTORY={{STACKABLE_LOG_DIR}}/containerdebug containerdebug --output={{STACKABLE_LOG_DIR}}/containerdebug-state.json --loop &"),

Copilot uses AI. Check for mistakes.
rust/crd/src/lib.rs
--role \"Admin\""
.to_string(),
"prepare_signal_handlers".to_string(),
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format! macro is used with placeholders like {STACKABLE_LOG_DIR} but no arguments are provided. If these braces are intended to be literal, escape them by using double braces (e.g. "{{STACKABLE_LOG_DIR}}") or provide the proper values.

Suggested change
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
format!("CONTAINERDEBUG_LOG_DIRECTORY={{STACKABLE_LOG_DIR}}/containerdebug containerdebug --output={{STACKABLE_LOG_DIR}}/containerdebug-state.json --loop &"),

Copilot uses AI. Check for mistakes.
rust/crd/src/lib.rs
]),
AirflowRole::Worker => command.extend(vec![
"prepare_signal_handlers".to_string(),
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format! macro is used with placeholders like {STACKABLE_LOG_DIR} but no corresponding arguments are provided. Either escape the curly braces if literal output is intended, or pass the needed variable values.

Suggested change
format!("CONTAINERDEBUG_LOG_DIRECTORY={STACKABLE_LOG_DIR}/containerdebug containerdebug --output={STACKABLE_LOG_DIR}/containerdebug-state.json --loop &"),
format!("CONTAINERDEBUG_LOG_DIRECTORY={}/containerdebug containerdebug --output={}/containerdebug-state.json --loop &", STACKABLE_LOG_DIR, STACKABLE_LOG_DIR),

Copilot uses AI. Check for mistakes.
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Apr 7, 2025

Apologies for the noise. Wanted to see what copilot would do (see slack thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@nightkr nightkr nightkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@razvan razvan

Labels

release/25.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@razvan @NickLarsenNZ @nightkr @lfrancke