Skip to content

Conversation

@Maleware
Copy link
Member

@Maleware Maleware commented Oct 29, 2024

Description

closes #337

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@Maleware
Copy link
Member Author

=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- PASS: kuttl (169.74s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_airflow-2.9.3_openshift-false (169.70s)
PASS

@Maleware
Copy link
Member Author

=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- PASS: kuttl (184.54s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_airflow-2.9.3_openshift-false (184.50s)
PASS

@adwk67 adwk67 self-requested a review October 30, 2024 08:27
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick glance, will leave the rest for andrew :)

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - I think some screenshots would help to explain how to use this feature from the UI-perspective.

Maleware and others added 3 commits October 31, 2024 14:10
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nightly tests all ran successfully locally.

@adwk67
Copy link
Member

adwk67 commented Oct 31, 2024

Suggested comment for the release notes:

OpenID Connect is now supported by the airflow operator: this means that the necessary Flask dependencies have been added to the product image and that the operator can process OIDC authentication classes. It will still be necessary, however, for users to configure their own webserver configuration themselves, if they want to be directly redirected to the authentication authority.

@Maleware Maleware added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 6529f52 Oct 31, 2024
@Maleware Maleware deleted the feature/tls-oidc branch October 31, 2024 15:10
@adwk67 adwk67 mentioned this pull request Nov 5, 2024
3 tasks
@Maleware
Copy link
Member Author

Maleware commented Nov 6, 2024

We will need a fix #530 this will complete the Ticket.

I forgot to add certificates to airflow via python certify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

OpenID Connect support

6 participants