Skip to content

Conversation

@kmodali
Copy link

@kmodali kmodali commented Oct 16, 2025

Related Issue(s):

Description:
Prototype Implementation of archive extension.

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@kmodali kmodali marked this pull request as ready for review October 17, 2025 15:06
@gadomski gadomski self-requested a review October 20, 2025 15:41
@jsignell
Copy link
Member

@kmodali it looks like the change that you intended to commit is entirely contained by 58f2a99 is that right? If so I can push to this branch to clean up the diff.

@kmodali
Copy link
Author

kmodali commented Oct 23, 2025

@jsignell Thanks for looking into this. Yes, you are right.

@jsignell
Copy link
Member

Ok! I just force pushed to your branch to tidy up the history.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

"version",
"view",
"xarray",
"archive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be sorted alphabetically.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I made the necessary modifications to maintain the alphabetical order.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't have any tests that exercise the new behavior. Please see other extensions (e.g. proj) for examples of the kind of tests we include with extensions.

@kmodali
Copy link
Author

kmodali commented Jan 6, 2026

@gadomski Sorry for the delay in reverting back, i noticed that the 'archive' extension specification https://github.com/stac-extensions/archive was updated a few weeks ago and accordingly the extension implementation has been modified. The test scripts, data files and the cassette files have been added to the repo. Thank you.

@gadomski gadomski self-requested a review January 6, 2026 14:14
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 91.32653% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (60eef08) to head (332bf6b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pystac/extensions/archive.py 91.30% 14 Missing and 2 partials ⚠️
pystac/extensions/ext.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   92.22%   92.20%   -0.03%     
==========================================
  Files          55       56       +1     
  Lines        8414     8610     +196     
  Branches      973      981       +8     
==========================================
+ Hits         7760     7939     +179     
- Misses        466      481      +15     
- Partials      188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants