make some hard-coded values into arguments#23
Open
letrout wants to merge 10 commits intossvb:masterfrom
Open
Conversation
added 10 commits
May 8, 2019 22:39
For clarity in how the test was run, print the buffer size and latency count parameters in the test output
add arguments for buffer size, latency size, latency count. Use the #deifnes as defaults
clang-8 complained about this missing when building in a FreeBSD cross-compiler
clang-8 complains about this
repo owner should select the version number if accepted
I plan to increment version to 0.5.0 for this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a situation where testing a newer CPU had larger L3 than the hard-coded SIZE (32MB). Rather than simply change this value in the code, I made it an argument so it can be be varied at runtime. While I was in there I did the same with BLOCKSIZE, LATBENCH_COUNT, and latbench_size for additional runtime flexibility. The original hard-coded values are used as defaults.