Skip to content

Terminate active Runners on FATAL shutdown #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yadij wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Terminate active Runners on FATAL shutdown #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/fatal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ fatal(const char *message)

storeDirWriteCleanLogs(0);

RunRegisteredHere(RegisteredRunner::finishShutdown);
Copy link
Copy Markdown
Contributor

@rousskov rousskov Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to being eliminated completely, fatal() and friends should eventually become an equivalent of "abort() without dumping core"1 -- an "immediate" and safe death with minimal reporting. This change moves Squid deeper into the opposite direction. No rationale has been provided to justify making things worse.

Footnotes

  1. Calls like std::terminate, std::exit(), and std::_Exit() should be evaluated to find the best match. ↩

Copy link
Copy Markdown
Contributor Author

@yadij yadij Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are certain system resources (eg listening ports, logs) which still should be released even when an abort() is happening. The criteria for finishShutdown runner fits well with the abort() situation.

Copy link
Copy Markdown
Contributor

@rousskov rousskov Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OS will take care of basic resources. No internal action is safe when "an abort() is happening". Nothing should be released by Squid itself when abort() is happening.


fatal_common(message);

exit(EXIT_FAILURE);
Expand Down Expand Up @@ -95,6 +97,8 @@ fatal_dump(const char *message)
if (opt_catch_signals)
storeDirWriteCleanLogs(0);

RunRegisteredHere(RegisteredRunner::finishShutdown);

Debug::PrepareToDie();
abort();
}
Expand Down
2 changes: 2 additions & 0 deletions src/tools.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,8 @@ death(int sig)

storeDirWriteCleanLogs(0);

RunRegisteredHere(RegisteredRunner::finishShutdown);

if (!shutting_down) {
PrintRusage();

Expand Down
Loading