-
Notifications
You must be signed in to change notification settings - Fork 31
Updated targetSDK to 34 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nilay-squareup
wants to merge
24
commits into
master
Choose a base branch
from
bump_targetSdk_to_34
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−28
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4ed872b
changed targetSDK to 34 also required dependency to run the project o…
Nilay-squareup bdc1246
update jdk to 17 for pipelines
Nilay-squareup 7490ec4
fixing proguard issue in pipelines
Nilay-squareup 314cad9
fixing notification permissions issue in pipelines
Nilay-squareup c8ddf57
fixing lint error for camera permission in pipelines
Nilay-squareup 5cfd44f
fixing pipeling for minifyEnable
Nilay-squareup 812a0b3
fixing ios pipelines
Nilay-squareup a018f91
fixing pipelines for ios
Nilay-squareup 822ce07
updated run script
Nilay-squareup 75fe91e
updated run script
Nilay-squareup 165ad9a
updated run phase
Nilay-squareup 1f39e5e
updated run phase
Nilay-squareup 85266d6
updated main.yml file
Nilay-squareup b7109a1
updated main.yml file
Nilay-squareup 0699476
updated main.yml file new
Nilay-squareup 0066174
yml file change and project.pbx file add
Nilay-squareup 3c0ec48
Update xcodebuild command to not using code signing
brandonjenniges f7137f0
Flutter ReaderSDK version update 4.0.2
Nilay-squareup bffe01a
Try to clean derived data after to clean up space
brandonjenniges b537b20
Extract out ios r1 version and use an env variable
brandonjenniges 3582c42
Merge pull request #119 from square/brandonjenniges/ci_fix
brandonjenniges e1bcc4a
reader sdk ios version bump to 1.7.4 and android 1.7.7
Nilay-squareup 1442195
Merge branch 'master' into bump_targetSdk_to_34
Nilay-squareup 1bf1fae
Resolve PR comments
Nilay-squareup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,58 @@ | ||
| name: reader-sdk-flutter-plugin | ||
|
|
||
| on: [push] | ||
|
|
||
| env: | ||
| IOS_READER_SDK_VERSION: 1.7.4 | ||
|
|
||
| jobs: | ||
| install-and-test: | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-java@v3 | ||
|
|
||
| - name: Cleanup | ||
| run: | | ||
| sudo rm -rf ~/Library/Developer/Xcode/DerivedData/* | ||
| sudo rm -rf ~/Library/Developer/Xcode/Archives/* | ||
| sudo rm -rf ~/Library/Caches/* | ||
| sudo rm -rf /Library/Developer/CoreSimulator/Profiles/Runtimes/* | ||
| sudo rm -rf /Users/runner/Library/Developer/CoreSimulator/Caches/* | ||
| sudo rm -rf /Users/runner/Library/Developer/CoreSimulator/Devices/* | ||
| sudo rm -rf /Users/runner/.gradle/caches | ||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
| - uses: subosito/flutter-action@v1 | ||
|
|
||
| - name: Set up Flutter | ||
| uses: subosito/flutter-action@v1 | ||
| with: | ||
| channel: 'stable' # or: 'beta', 'dev' or 'master' | ||
| - run: flutter pub get | ||
| # Android | ||
| - run: | | ||
| channel: 'stable' | ||
|
|
||
| - name: Install dependencies | ||
| run: flutter pub get | ||
|
|
||
| - name: Android | ||
| run: | | ||
| cd example | ||
| flutter pub get | ||
| cd android | ||
| ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} | ||
| # #IOS | ||
| - run: | | ||
|
|
||
| - name: iOS | ||
| run: | | ||
| cd example | ||
| flutter pub get | ||
| cd ios | ||
| ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} --repo-password ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} --version 1.6.1 > /dev/null | ||
| ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} --repo-password ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} --version $IOS_READER_SDK_VERSION > /dev/null | ||
| flutter clean | ||
| rm Pods && rm Podfile.lock | ||
|
|
||
| flutter pub get | ||
| pod update Firebase/CoreOnly | ||
| pod install --repo-update | ||
| xcodebuild -workspace Runner.xcworkspace -configuration Debug -scheme Runner -destination "platform=iOS Simulator,OS=16.2,name=iPhone 14" | ||
| xcodebuild -workspace Runner.xcworkspace -configuration Debug -scheme Runner -sdk iphoneos SKIP_SETUP_SCRIPT=YES CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| ## Changelog | ||
|
|
||
| ### v4.0.2 Sep 18, 2024 | ||
|
|
||
| * Upgrade to Reader SDK 1.7.7 on Android. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this version also update to 1.7.4 on iOS? |
||
|
|
||
| ### v4.0.1 Aug 29st, 2024 | ||
|
|
||
| * Upgrade to Reader SDK 1.7.5 on Android. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.