Adopt a full modern gradle build#9292
Merged
yschimke merged 15 commits intosquare:masterfrom Feb 3, 2026
Merged
Conversation
Use for 1 feature, publishing. And also move current buildSrc logic there. First step to cleaning up build logic generally.
Testing what a modern structure would look like, and what work would be required.
# Conflicts: # gradle/libs.versions.toml # module-tests/build.gradle.kts
swankjesse
approved these changes
Feb 2, 2026
|
|
||
| dependencies { | ||
| // Logic for signatures should be moved to the applying module or configured via extension | ||
| // For now, we'll keep the standard ones and allow modules to add more |
Collaborator
Author
There was a problem hiding this comment.
I ended up reconfiguring the okcurl one, to only use jvm. But we can us this as a starting point to define how this should work.
| jlink = "0.7" | ||
| jetbrains-annotations = "26.0.2-1" | ||
| jnr-unixsocket = "0.38.24" | ||
| jsoup = "1.22.1" |
Collaborator
There was a problem hiding this comment.
Seems like most of these are referenced only once, not saving much? Though I do enjoy uniformity
Collaborator
Author
There was a problem hiding this comment.
Yep - we had inconsistencies, and it was hard to know where to look for versions.
Collaborator
Author
There was a problem hiding this comment.
if anything, I'd like to have a clear pattern and apply it even more consistently.
| description = "Get 'gradlew jvmTest' to run the tests of JVM-only modules" | ||
| dependsOn(test) | ||
| } | ||
| plugins { |
Collaborator
Author
There was a problem hiding this comment.
if anything I went overbooard. The dokka config could have stayed.
yschimke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to a modern gradle structure.
This went too far, but looks promising to adopt and quickly iterate on.
There is some risk of non-obvious changes, to follow up putting more guardrails in place before next release.