Open
Conversation
b5fb8b2 to
f96124b
Compare
|
Overall looks great to me, just a question from my side regarding to |
Collaborator
Author
Internally, |
gracevivi523
approved these changes
Mar 18, 2025
2490ea8 to
2be0815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
cascadeis coupled toprefecteven though there is no fundamental reason that requires this. Users should be able to use this library withoutprefect. Therefore, this change keeps the existing functionality but requires the user to installprefectin their environment if they wish for the code path of automatic inference to be activated.Therefore this change introduces the following:
prefectis now an extraprefect<2support is droppedContextis introduced to represent the execution environment in which different implementations can obtain values that may be needed for remote submission of a job.prefectimports from the common entrypoints