Fix Docker latest tag for DuckDB variant#1332
Merged
Merged
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latesttag in the manifest publishing job.Why
docker/metadata-actionhandleslatestspecially. The existingsuffix=-duckdbproduced suffixed version tags such asv0.44.1-duckdb, but did not suffixlatest, so the DuckDB manifest could publishlovasoa/sqlpage:latest.With
onlatest=true, tag pushes should produce:vX.Y.Z,latestvX.Y.Z-duckdb,latest-duckdbValidation
git diff --check -- .github/workflows/ci.ymlactionlint -shellcheck '' .github/workflows/ci.ymlI also ran plain
actionlint .github/workflows/ci.yml; it reports an existing shellcheck warning in the manifest creation script, unrelated to this metadata-line change.