Upgrade swagger-core from version 2.2.43 to 2.2.45#3245
Draft
Mattias-Sehlstedt wants to merge 1 commit intospringdoc:mainfrom
Draft
Upgrade swagger-core from version 2.2.43 to 2.2.45#3245Mattias-Sehlstedt wants to merge 1 commit intospringdoc:mainfrom
Mattias-Sehlstedt wants to merge 1 commit intospringdoc:mainfrom
Conversation
2 tasks
| "openapi": "3.0.1", | ||
| "info": { | ||
| "TEST": "HELLO" | ||
| "x-TEST": "HELLO" |
Contributor
Author
There was a problem hiding this comment.
This is an example of an adjustment needed for caveat 2
| }, | ||
| "PageMetadata": { | ||
| "type": "object", | ||
| "type": "null", |
Contributor
Author
There was a problem hiding this comment.
This is an example of an issue coming from Caveat 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known caveats
@Nullableleaks the nullable to array items. Reported in [Bug]: Issues using @Nullable annotations in OpenAPI 3.1 schemata swagger-api/swagger-core#5077. The annotation also incorrectly leaks to objects, so that they will be markednullable: trueortype: null. I know the cause and the fix but I am waiting for the first ticket to be resolved before I implement that fix.x-" gets dropped."additionalProperties": {}becomes"additionalProperties": {"type": "object"}This new definition does not mean the same as the first, and I would argue that the first is more correct forMap<String, Object>in Java. But it depends on ifObjectin the map is expected to be a Json-deserializable value or something more flat/simple.