Add PrincipalIdentifierStrategy to SessionRegistryImpl for custom principal matching#18794
Closed
98001yash wants to merge 1 commit intospring-projects:mainfrom
Closed
Conversation
Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
@98001yash Thanks for the PR, however, gh-18622 requires a bug fix in Closing this in favour of eefbb4d |
jgrandja
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a pluggable PrincipalIdentifierStrategy
to SessionRegistryImpl to allow custom principal matching logic.
Currently, SessionRegistryImpl relies on equals() when determining
whether two principals represent the same user. In OAuth2/OIDC
scenarios, principal instances (e.g. DefaultOidcUser) may differ
across authentications due to varying attributes, causing
session management (such as maximumSessions) to treat the same
logical user as distinct principals.
This enhancement allows applications to provide a custom
PrincipalIdentifierStrategy to define logical identity matching,
while preserving the existing equals()-based behavior by default
for backward compatibility.
Tests have been added to verify:
Fixes gh-18622