Skip to content

Comments

Add postProcessor to SpringOpaqueTokenIntrospector Builders#18625

Merged
jzheaux merged 2 commits intospring-projects:mainfrom
itsmevichu:gh-18623
Feb 18, 2026
Merged

Add postProcessor to SpringOpaqueTokenIntrospector Builders#18625
jzheaux merged 2 commits intospring-projects:mainfrom
itsmevichu:gh-18623

Conversation

@itsmevichu
Copy link
Contributor

Fixes #18623

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @itsmevichu! Thanks for the PR. I've left some feedback inline. In addition to my feedback, will you please add unit tests for both implementations that demonstrate that the new feature works?

@jzheaux jzheaux self-assigned this Feb 10, 2026
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2026
@itsmevichu itsmevichu requested a review from jzheaux February 11, 2026 20:07
@jzheaux
Copy link
Contributor

jzheaux commented Feb 12, 2026

Hi, @itsmevichu! Thanks for the update! Will you please remove the authenticationConverter method since postProcessor can serve that purpose?

@itsmevichu itsmevichu changed the title Add authenticationConverter to SpringOpaqueTokenIntrospector Builders Add postProcessor to SpringOpaqueTokenIntrospector Builders Feb 17, 2026
@itsmevichu
Copy link
Contributor Author

I have removed the authenticationConverter method; And FYI, the @since version needs to be updated before merging.

itsmevichu and others added 2 commits February 17, 2026 17:06
Closes spring-projectsgh-18623

Signed-off-by: itsmevichu <vishnutheep@gmail.com>
- Add @SInCE version
- Change variable name to match method name

Issue spring-projectsgh-18623

Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
@jzheaux jzheaux added this to the 7.1.0-M3 milestone Feb 18, 2026
@jzheaux jzheaux enabled auto-merge (rebase) February 18, 2026 00:07
@jzheaux
Copy link
Contributor

jzheaux commented Feb 18, 2026

Thanks again, @itsmevichu for the PR and for your timely updates. This will merge into main once the build completes.

@jzheaux jzheaux merged commit fc48088 into spring-projects:main Feb 18, 2026
7 checks passed
@itsmevichu
Copy link
Contributor Author

Thanks! Glad I could contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make authenticationConverter customizable in SpringOpaqueTokenIntrospector.Builder

3 participants