Support single-line PEM encoded RSA keys in RsaKeyConverters#18599
Open
earlgrey02 wants to merge 1 commit intospring-projects:mainfrom
Open
Support single-line PEM encoded RSA keys in RsaKeyConverters#18599earlgrey02 wants to merge 1 commit intospring-projects:mainfrom
RsaKeyConverters#18599earlgrey02 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: earlgrey02 <san06036@naver.com>
earlgrey02
force-pushed
the
support-single-line-rsa-key
branch
from
2ab3976 to
93761f8
Compare
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RsaKeyConverterscurrently assumes that PEM-encoded RSA keys are provided in a multi-line format, where the PEM header, footer, and Base64-encoded content are separated across multiple lines.However, in environment variable–based configurations (ex.
.envfiles), PEM keys are commonly stored as single-line strings, with newline characters removed or escaped.Examples:
-----BEGIN PUBLIC KEY-----MIIBIjANBgkq...IDAQAB-----END PUBLIC KEY----------BEGIN PUBLIC KEY-----\nMIIBIjANBgkq...IDAQAB\n-----END PUBLIC KEY-----While these representations are functionally equivalent to the traditional multi-line PEM format, they are currently not supported by
RsaKeyConvertersand result in conversion failures.Therefore, this PR improves
RsaKeyConvertersto correctly handle single-line RSA keys while preserving the existing conversion structure.