Update servlet/architecture.adoc to use include-code#18536
Merged
rwinch merged 2 commits intospring-projects:mainfrom Feb 23, 2026
Merged
Update servlet/architecture.adoc to use include-code#18536rwinch merged 2 commits intospring-projects:mainfrom
rwinch merged 2 commits intospring-projects:mainfrom
Conversation
52cc963 to
7920826
Compare
Also update antora.xml to include-xml in docs/src/test/resources Signed-off-by: Joe Kuhel <4983938+jkuhel@users.noreply.github.com>
7920826 to
909ee59
Compare
909ee59 to
ac7596b
Compare
ac7596b to
4c9ee66
Compare
Member
|
Thanks for the PR! There were a few changes that I applied:
|
- Switch `include-java` (does not exist) to `include-code` - Update kotlin to have the `disable` tag - Update to suppress deprecation use for User builder (allowed for samples) Signed-off-by: Robert Winch <362503+rwinch@users.noreply.github.com>
4c9ee66 to
0c39469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the servlet architecture (
servlet/architecture.adoc) docs to useinclude-codeblock macro and included some additional unit tests.Also updated the
docs/antora.xmlconfiguration to addinclude-xmlwhich is configured todocs/src/test/resources. This allowed theinclude-codemacro to include XML-based snippets (e.g. the creation of thenullRequestCachebean).The only sample that did not use
include-codewas the following due to theFilterRegistrationBeanfrom the Spring Boot project not being available.E.g.
References #16226