Use immutable map for static cache in TypeDescriptor#36813
Open
kilink wants to merge 1 commit into
Open
Conversation
Switch to Map.of for the static commonTypesCache field for immutability. Signed-off-by: Patrick Strawderman <pstrawderman@netflix.com>
kilink
force-pushed
the
type-descriptor-immutable-cache
branch
from
089e82f to
8485956
Compare
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to Map.of for the static commonTypesCache field for immutability.
The rationale for this change is one of hygiene (the read-only map should be immutable), and the fact that the immutable collections added in Java 9 are "trusted" by the JVM and therefore can be constant folded (see a similar JDK issue here where legacy code is being switched the modern immutable collections). I don't have any benchmark supporting any claim in that area, and it would be workload dependent obviously, but it seems like one of those worthwhile changes regardless. If there's alignment there are likely a few other places in spring that could be modernized in this respect.
Note that The
valueOfstatic factory couldn't be used here since it tries to read from the staticcommonTypesCachefield, which with this change wouldn't be initialized yet.