Skip to content

Conversation

@nillpoe
Copy link

@nillpoe nillpoe commented Jan 21, 2026

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #3445

Signed-off-by: NillPoe <nillpoe@pm.me>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2026
Signed-off-by: NillPoe <nillpoe@pm.me>
@mp911de
Copy link
Member

mp911de commented Jan 21, 2026

Thanks for your contribution. I think your pull request should not be required once we've merged #3409. Can you check out the code at #3409 to verify typed property paths will achieve what you're looking for?

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Jan 21, 2026
@nillpoe
Copy link
Author

nillpoe commented Jan 21, 2026

Hi, thanks for the reply. I missed that one because the search for "sort" didn't yield it.
Yes, I think that is another form of Kotlin typed-property support.

But this change will allow you to choose between ascending and descending more easily in most use case.
So I don't really think #3409 closes this PR.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 21, 2026
@mp911de
Copy link
Member

mp911de commented Jan 21, 2026

Introducing an universal extension for ordering can cause confusion in other contexts, additionally, there is much more detail associated with sorting (such as sorting by multiple properties, nulls precedence), therefore we would not want to add this specific extension.

@mp911de mp911de closed this Jan 21, 2026
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Kotlin extension for Sort

3 participants