Monitor truststore certificates in SslMeterBinder#49641
Open
bbbbooo wants to merge 2 commits intospring-projects:mainfrom
Open
Monitor truststore certificates in SslMeterBinder#49641bbbbooo wants to merge 2 commits intospring-projects:mainfrom
bbbbooo wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: bbbbooo <hyeons1213@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
.../main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: bbbbooo <hyeons1213@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SslMeterBindercurrently publishes expiry metrics only for certificate chains from the key store.As a result, trust store certificate chains are not included in
ssl.chain.expirymetrics and their expiry cannot be monitored.When the same chain alias exists in both the key store and trust store, the metrics also need a way to distinguish their source.
Changes
Update
SslMeterBinderto publish expiry metrics for trust store certificate chains in addition to key store chains.Add a
storetag with valueskeyandtrustso that key store and trust store metrics can be distinguished.Update the reference documentation for
ssl.chain.expiryto describe trust store coverage and the new tag.Tests
Added/updated tests to cover.
Fixes #49325