Skip to content

Use MergedContextConfiguration.hasResources()#49504

Closed
sbrannen wants to merge 1 commit intospring-projects:mainfrom
sbrannen:assertHasClassesOrLocations
Closed

Use MergedContextConfiguration.hasResources()#49504
sbrannen wants to merge 1 commit intospring-projects:mainfrom
sbrannen:assertHasClassesOrLocations

Conversation

@sbrannen
Copy link
Member

@sbrannen sbrannen commented Mar 8, 2026

This PR simplifies the implementation of SpringBootContextLoader by using MergedContextConfiguration.hasResources().

Simplify the code by using MergedContextConfiguration.hasResources().
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2026
@wilkinsona
Copy link
Member

Thanks for the PR, @sbrannen, but I think this might be dead code now. I've opened #49518.

@wilkinsona wilkinsona closed this Mar 9, 2026
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 9, 2026
@sbrannen
Copy link
Member Author

sbrannen commented Mar 9, 2026

I've subscribed to that other issue.

Thanks for looking into it.

@wilkinsona
Copy link
Member

Re-opening as this isn't a dead code path.

@wilkinsona wilkinsona reopened this Mar 9, 2026
@wilkinsona wilkinsona added this to the 3.5.x milestone Mar 9, 2026
@wilkinsona wilkinsona self-assigned this Mar 9, 2026
@wilkinsona wilkinsona added type: task A general task and removed status: declined A suggestion or change that we don't feel we should currently apply labels Mar 9, 2026
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.12 Mar 9, 2026
wilkinsona pushed a commit that referenced this pull request Mar 9, 2026
Simplify the code by using MergedContextConfiguration.hasResources().

See gh-49504
@wilkinsona wilkinsona closed this in 3e1b819 Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants